[merge] feat(metrics) histograms with user-defined bins #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feat/custom-histograms-merge
branch
from
fa87343
to
2dbd177
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
===================================================
- Coverage 90.80161% 90.68720% -0.11441%
===================================================
Files 52 52
Lines 11165 11103 -62
===================================================
- Hits 10138 10069 -69
- Misses 1027 1034 +7
... and 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thibaultcha
force-pushed
the
feat/custom-histograms-merge
branch
4 times, most recently
from
cca9f01
to
01ed9b9
Compare
This feature is only available through the FFI.
If a user provides a list of numbers when defining a histogram, those
numbers will be used as the upper-bounds of the histogram's bins.
For instance, the following code:
local shm = require "resty.wasmx.shm"
shm.metrics:define("h", shm.metrics.HISTOGRAM, { bins = { 1, 3, 5 } })
Creates a histogram with bins `[0, 1] (1, 3] (3, 5] (5, Inf+]`.
Signed-off-by: Thibault Charbonnier <[email protected]>
thibaultcha
force-pushed
the
feat/custom-histograms-merge
branch
from
c5e5550
to
321e69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.